Forums
Dates and times are way more complicated than we usually think they are, especially when we're talking about historical dates and times. The solution, of course, is to always use someone else's work, whether it's a library or your language's built-ins, never implement date handling yourself.
For a long time, though, Java's date handling left something to be desired. Which is why Sven found this history lesson in his company's code base:
Many years ago, at the height of the Industrial Revolution, the United States was criscrossed by a riot of regional railroads. Gradually, these were acquired or merged until now there are only about a half-dozen major national railroads. In a similar fashion, at the birth of the public Internet, there must have been thousands of community Internet service providers. It seemed like every town had its own entrepeneurial enterprise, with some racks of modems in an office somewhere. Those quickly got snapped up or forced into bankruptcy, as legacy cable telecoms companies leveraged their existing monopolies into a new line of business. Which brings us to this week's Error'd. Enjoy(?) it.
First up, Adrian McCarthy grumbles "Getting help can be difficult when your regional monopoly internet service provider cannot assemble a functional web site. Note that the understandably required Description field in this online support contact form is disabled."
Ah, the joys of stringly typed code. Everything can be turned into a string, so why not treat everything as a string? It certainly worked for Sebastian's co-worker, who also took it to another level:
Feb 23If GetTrainAtStation(aTrainNo.ToString) Is Nothing Then
iTheTrainAtStation.Add(String.Format("{0}", aTrainNo.ToString), aTrainAtStationItem)
End If
We like using constants instead of magic numbers. Today, we see an unusual misuse of them. It's unusual because, while it's a set of bad choices, it's not quite a `#define ONE 1` level of silliness.
First, a little background. Benjamin inherited a building automation system. This building automation system was implemented in Microsoft's Visual C++, version 6.0, way back in the 90s. As of the late 2010s, not only was it still in use, it was still pinned to the same compiler version. So not exactly the most modern of applications, but it accomplished the business goals, albeit with a lot of bugs, errors, and mysterious glitches.
Pretty much all object oriented languages have some concept of "destruction": objects need to release any resources they acquired at construction. In a lot of cases, we don't need to customize this terribly much, but when we do, it's vitally important to do it correctly.
Nancy's co-worker perhaps didn't understand the "correctly" part. So this was the standard pattern of C++ destructor that they wrote:
Managing the requirements for an application is a huge challenge. The hardest part of the challenge is that, very frequently, the user's don't know what they really want or need. Prying it out of them, and giving them an application that actually solves the real problem they have, is an art.
The worst situation is when the users are absolutely certain that they do know what they want. This was the situation that Irini found herself in.
We got quite a few irregular submissions this week from regular contributors. Which is to say routine contributors. We're not qualified to make judgements about whether or not anyone is what what most folks would call normal.
First up, Isaac D. is struggling with localization, kvetching "Apparently this number format is ALIVE and WELL in parts of India and Afghanistan, but us poor Australians on desktop browsers also seem to be visually assaulted with it. I wonder if the Zuck will pay me $1,00,000 for reporting it or do real country borders mean nada in the Metaverse? ;)" This would ordinarily be controlled by some operating system or browser configuration, would it not?
James's management had more work than they had staffing for, so they did what any company would do in that situation: expand their staff. No, of course not, I'm kidding. They bundled up a pile of work and shipped it off to the contractor who gave them the lowest bid, provided absolutely no oversight or code-quality standards in the contract, and hoped for the best.
What they got back was a gigantic pile of code that compiled. That is the only positive thing one can say about the code, because it certainly didn't work. Within a few weeks of starting reviewing the gigantic pile of garbage the contractors turned in, the dev team reached the decision that it would be quicker to rewrite from scratch than it was to try and pick apart the trashpile and reshaped the refuse into something approaching their actual requirements.
Mira was trawling through some old Python code. This particular block of code needed to load some data from JSON. The data was an array, and the code needed to know how long the array was.
Python has a handy len function that does this on anything enumerable. If our developer had used len, we'd be looking at different code today.
One of Tim's co-workers needed to handle a simple condition: if a control in their web app was enabled, show it, otherwise hide it.
Now, if you or I were writing that, we might write some awfully verbose code, like:
Iterating across a list is a very simple task. It's a CS-101 type thing, and if anything, it's the one thing I'd expect any developer to be able to do without confusing me too much.
Brendan has a co-worker that wants to change my mind about this.
IBM Profs was introduced in 1980 including both email and calendaring support. Online calendaring is now old enough to have grandchildren, but we still can't get the simplest things right.
As our friend Romeo rhetorically wonders "Million dollar question: What calendar does Microsoft use?"
If you're writing an application with a drop-down list, it's typical and reasonable to auto-select a certain option in the list. But John found an approach to doing this that's anything but typical.
function selectsearch(myform, myselect, myinput) {
var i = 0;
var fvalue = 1;
do {
arrayresult = eval(myform+"."+myselect+".options["+i+"].value");
if (arrayresult == myinput) {
eval(myform+"."+myselect+".options["+i+"].selected = true");
var fvalue=5;
}
i++;
} while(fvalue<3);
}
Gennifer had a job. Her employer got bought out by another company, and the purchaser was notorious for gobbling up companies, taking over their processes, and then doing mass layoffs. Seeing the writing on the wall, Gennifer started job hunting.
Before too long, she had two very likely candidates. The first was Initrode. It wasn't a great match- Gennifer's skills didn't overlap well, and while the salary was respectable, it wasn't as good as the other position, at Initech.
Another day, another terrible way to validate integers. Today's submission comes from Sluiper.
This approach, at least, contains a mild bit of cleverness. It's not the good kind of cleverness that makes a complicated problem more clear and easier to understand, but the bad kind that exploits assumptions about low-level technical details.
Sandra, still at InitAg, has to work with Brad. Some time ago, Brad was assigned a slew of front-end development tasks, since he's a web developer. But Brad isn't a front-end developer, and doesn't really have a good grasp of front-end development. Management isn't clear on the difference: "Aren't you a web developer? I don't care which end you use, just develop." Brad is also game to tackle whatever task is assigned to him, regardless of whether he has any sense of how to solve the problem.
When Brad needed to display data on a map, the requirements wanted the map layers to be distinguished by color. So Brad did the usual thing one might do in this situation: he created a gigantic array of all possible colors that might be used on the map. Actually, he created two: colors and colorsBlackWhite.
Automotive afficionado Mike S. proudly relates "My first and only car has been a classic 1965 6-cyl Ford Null. I've always loved it but it does crash from time to time, even though I've received many pointers on how to avoid that. I've considered getting an Infiniti and then would divide my time between the two." Avoid pointers, Mike.
Pieter-Jan needed to add some features to a PHP-based site for managing student assessments. Students would complete projects, submit them, and then receive feedback from their peers. The number of peers providing feedback is variable, so the application has to manage that. Which, you might be thinking, "that sounds like not a big deal to manage," but for Pieter-Jan's predecessor, it seems like it may have been.
if($i > '0') {
$team=array($studentName1,$content1,$motivation1,$isTeamMate1);
}
if($i > '1') {
$team=array($studentName1,$content1,$motivation1,$isTeamMate1,$studentName2,$content2,$motivation2,$isTeamMate2);
}
if($i > '2') {
$team=array($studentName1,$content1,$motivation1,$isTeamMate1,$studentName2,$content2,$motivation2,$isTeamMate2,$studentName3,$content3,$motivation3,$isTeamMate3);
}
Stack V supports a web application that accepts regexes from users. For legacy reasons, the users must supply the surrounding / characters, as well. There was some validation to ensure that the inputs were correct, but QA discovered that invalid regular expressions were getting through.
They filed a bug, it got triaged, and then shipped off to a contractor to patch. This was the contractor's solution: